deps: update googletest to ec4fed9 #48538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dependencies
tniessen
approved these changes
Jun 24, 2023
There was a problem hiding this comment.
Looks correct. The upstream commit google/googletest@ec4fed9 landed more than 48 hours before this PR was opened, as intended.
github-actions
bot
removed
the
request-ci
tniessen
added
the
author ready
lpinca
approved these changes
Jun 24, 2023
VoltrexKeyva
approved these changes
Jun 24, 2023
aduh95
reviewed
Jun 24, 2023
| @@ -189,7 +189,7 @@ In practical terms, Corepack will let you use Yarn and pnpm without having to | |||
| install them - just like what currently happens with npm, which is shipped | |||
| by Node.js by default. | |||
|
|
|||
| ### googletest | |||
| ### googletest ec4fed9 | |||
There was a problem hiding this comment.
This is a bit weird, it's the only one in the list that uses a hash as version number..
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5e5a01b |
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
PR-URL: #48538 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48538 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48538 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 10, 2023
PR-URL: #48538 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
PR-URL: #48538 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of googletest to ec4fed9.